10000 [MRG+1] fowlkes_mallows_score: unit tests (Fixes #8101) by devanshdalal · Pull Request #8140 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] fowlkes_mallows_score: unit tests (Fixes #8101) #8140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2017
Merged

[MRG+1] fowlkes_mallows_score: unit tests (Fixes #8101) #8140

merged 2 commits into from
Jan 3, 2017

Conversation

devanshdalal
Copy link
Contributor
@devanshdalal devanshdalal commented Jan 1, 2017 •
edited
Loading

Fixes #8101

What does this implement/fix? Explain your changes.

Added one more unit test for fowlkes_mallows_score() in sklearn.metrics.cluster module as discussed in the issue #8101

jnothman
jnothman reviewed Jan 1, 2017
View reviewed changes
Copy link
Member
@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks a little more thorough. LGTM, thanks

@jnothman jnothman changed the title [MRG] fowlkes_mallows_score: unit tests (Fixes #8101) [MRG+1] fowlkes_mallows_score: unit tests (Fixes #8101) Jan 1, 2017
@raghavrv
Copy link
Member
raghavrv commented Jan 3, 2017

Could you fix the flake 8 tests in travis?

raghavrv
raghavrv approved these changes Jan 3, 2017
View reviewed changes
Copy link
Member
@raghavrv raghavrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merge apart from the flake8 issue

@devanshdalal
Copy link
Contributor Author

@raghavrv , did it.

@jnothman
Copy link
Member
jnothman commented Jan 3, 2017

Thanks!

@jnothman jnothman merged commit 2cb7e47 into scikit-learn:master Jan 3, 2017
raghavrv pushed a commit to raghavrv/scikit-learn that referenced this pull request Jan 5, 2017
@devanshdalal @raghavrv
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
ca48e9d 
…) (scikit-learn#8140)
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@devanshdalal @sergeyf
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
2fa1b0e 
…) (scikit-learn#8140)
@Przemo10 Przemo10 mentioned this pull request Mar 17, 2017
Closed
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@devanshdalal @Sundrique
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
6c4e244 
…) (scikit-learn#8140)
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@devanshdalal @NelleV
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
0579e9e 
…) (scikit-learn#8140)
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@devanshdalal @paulha
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
4a53dec 
…) (scikit-learn#8140)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@devanshdalal @maskani-moh
[MRG+1] fowlkes_mallows_score: more unit tests (Fixes scikit-learn#8101…
194417e 
…) (scikit-learn#8140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman left review comments

@raghavrv raghavrv raghavrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fowlkes_mallows_score returns nan in binary classification
3 participants
@devanshdalal @raghavrv @jnothman
0