[MRG + 1] Set min_impurity_split in gradient boosting models #8007
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test to check that it now works as expected? |
8000
f1c355e to
50e30b2
Compare
|
@amueller I added a test function to the PR |
nelson-liu
reviewed
Dec 11, 2016
| @@ -961,6 +961,18 @@ def test_max_leaf_nodes_max_depth(): | |||
| assert_equal(tree.max_depth, 1) | |||
|
|
|||
|
|
|||
| def test_min_impurity_split(): | |||
| # Test precedence of max_leaf_nodes over max_depth. | |||
There was a problem hiding this comment.
perhaps change this comment? Thanks for looking into this!
50e30b2 to
5385982
Compare
|
Good catch, I updated the comment. |
|
Can you please add an entry to whatsnew.rst to the bugfix section? Otherwise LGTM. |
5385982 to
c901cc5
Compare
|
Done, I added an entry to whats_new |
self.min_impurity_split should be passed to DecisionTreeRegressor in BaseGradientBoosting._fit_stage. Fixes scikit-learn#8006
c901cc5 to
b48fb08
Compare
|
LGTM |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #8006
What does this implement/fix? Explain your changes.
Pass
self.min_impurity_splittoDecisionTreeRegressorinBaseGradientBoosting._fit_stage.