8000 [MRG + 1] Replace ConvergenceWarning by RuntimeWarning when cumsum in unstable by lesteve · Pull Request #7922 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG + 1] Replace ConvergenceWarning by RuntimeWarning when cumsum in unstable #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2016
Merged

[MRG + 1] Replace ConvergenceWarning by RuntimeWarning when cumsum in unstable #7922

merged 1 commit into from
Nov 24, 2016

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Nov 22, 2016 •
edited
Loading

As per #7376 (comment).

Note, this is a change compared to 0.18.1 but I feel users should not be affected by a change of warning type. Shout if you feel otherwise.

@lesteve lesteve mentioned this pull request Nov 22, 2016
Merged
@amueller
Copy link
Member

LGTM

@amueller amueller changed the title [MRG] Replace ConvergenceWarning by RuntimeWarning when cumsum in unstable [MRG + 1] Replace ConvergenceWarning by RuntimeWarning when cumsum in unstable Nov 23, 2016
@TomDLT
Copy link
Member
TomDLT commented Nov 24, 2016

LGTM

@TomDLT TomDLT merged commit 0847c92 into scikit-learn:master Nov 24, 2016
@lesteve lesteve deleted the stable-cumsum-runtimewarning branch November 28, 2016 07:40
sergeyf pushed a commit to sergeyf/scikit-learn that referenced this pull request Feb 28, 2017
@lesteve @sergeyf
Replace ConvergenceWarning by RuntimeWarning (scikit-learn#7922)
2675012 
when cumsum is unstable.
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@lesteve @Sundrique
Replace ConvergenceWarning by RuntimeWarning (scikit-learn#7922)
b24a33b 
when cumsum is unstable.
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@lesteve @NelleV
Replace ConvergenceWarning by RuntimeWarning (scikit-learn#7922)
c6cd6b2 
when cumsum is unstable.
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@lesteve @paulha
Replace ConvergenceWarning by RuntimeWarning (scikit-learn#7922)
bd1cf10 
when cumsum is unstable.
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@lesteve @maskani-moh
Replace ConvergenceWarning by RuntimeWarning (scikit-learn#7922)
a400838 
when cumsum is unstable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @amueller @TomDLT
0