8000 Fixes issue #7751 by visheshmistry · Pull Request #7807 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Fixes issue #7751 #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

visheshmistry
Copy link
@visheshmistry visheshmistry commented Nov 1, 2016

Reference Issue

Fixes #7751

What does this implement/fix? Explain your changes.

In 8000 scikit-learn/sklearn/metrics/classification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue

Any other comments?

The additional file - test1.py is for testing purpose and I have deleted it in my further commit

Vishesh Mistry added 4 commits November 1, 2016 15:09
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
…ssification.py under the function classification_report , a check is made to make sure that if the user enters the elements of target_names the size of that is checked with the size of labels. If the size is unequal, a warning is raised which will inform the user about the issue
@lesteve
Copy link
Member
lesteve commented Nov 2, 2016

@vishesh9494 there is already a PR tackling this issue that was opened before yours #7802 by @kennmyers. Quickly looking at it it seems like #7802 is closer to being mergable than this PR so I am closing this one.

@vishesh9494 sorry for the duplicated work, don't hesitate to look for another issue to work on.

@lesteve lesteve closed this Nov 2, 2016
@visheshmistry
Copy link
Author

@lesteve It is alright. I am really looking forward to contributing here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raise warning if labels and target_names have different length in classification_report
2 participants
0