changed address for nose #7592
changed address for nose #7592
Conversation
…r testing since the nose project web site suggests new projects should consider using Nose2, or py.test?
|
we have long term goals to convert tests to py.tests (see #7319) |
| @@ -377,7 +377,8 @@ Testing scikit-learn once installed | |||
| ----------------------------------- | |||
|
|
|||
| Testing requires having the `nose | |||
| <https://somethingaboutorange.com/mrl/projects/nose/>`_ library. After | |||
| <https://nose.readthedocs.io/en/latest/>`_ library. After | |||
|
|
|||
There was a problem hiding this comment.
i think this newline is extraneous
|
Yes, I think a rebasing error re-broke it. |
|
got rid of the extra line. |
| @@ -377,7 +377,7 @@ Testing scikit-learn once installed | |||
| ----------------------------------- | |||
|
|
|||
| Testing requires having the `nose | |||
| <https://somethingaboutorange.com/mrl/projects/nose/>`_ library. After | |||
| <https://nose.readthedocs.io/en/latest/>`_ library. After | |||
There was a problem hiding this comment.
fwiw, i think the site is HTTP, not HTTPS
|
https is fine On 7 October 2016 at 08:28, Nelson Liu notifications@github.com wrote:
|
|
I doubled-checked the link on the CircleCI build here and it works, so merging this one, thanks! |
Reference Issue
Fixes #7586
and
#6132
What does this implement/fix? Explain your changes.
Changed link for Nose testing to new link. This fix has been made before. So not sure how it snuck back in. see issue #6132
Any other comments?
Should tests be converted to Nose2? If I did that would it get merged? The nose project is no longer being maintained according to its web site.