fixing issue #7474 fix selectFDR bug. #7509
Conversation
…dr_regression needs change. Seems to fail randomly
|
@fabianegli : fixed pep8 problems. But looks like a test might fail randomly.. will test a few times and update the test case too if needed. |
|
8000
Can't reproduce failure of test_select_fdr_regression test case. after about 10 repeated runs of |
| @@ -596,7 +596,9 @@ def _get_support_mask(self): | |||
|
|
|||
| n_features = len(self.pvalues_) | |||
| sv = np.sort(self.pvalues_) | |||
| selected = sv[sv <= float(self.alpha) / n_features * (np.arange(n_features) + 1)] | |||
| selected = sv[sv <= float(self.alpha) / n_features | |||
There was a problem hiding this comment.
Put the * operator at the end of the line instead of the start of the following line.
| @@ -596,7 +596,9 @@ def _get_support_mask(self): | |||
|
|
|||
| n_features = len(self.pvalues_) | |||
| sv = np.sort(self.pvalues_) | |||
| selected = sv[sv <= float(self.alpha) / n_features * (np.arange(n_features) + 1)] | |||
| selected = sv[sv <= float(self.alpha) / n_features | |||
| * (np.arange(n_features) + 1)] | |||
There was a problem hiding this comment.
Indent this line to align with the opening square bracket.
| selected = sv[sv <= float(self.alpha) / n_features * (np.arange(n_features) + 1)] | ||
| selected = sv[sv <= float(self.alpha) / n_features | ||
| * (np.arange(n_features) + 1)] | ||
| print(selected) |
There was a problem hiding this comment.
Oops.. that was in preparation for testing and fixing test-case.. never needed and I forgot.. fixed now.
There was a problem hiding this comment.
Plese check and fix the tho other comments as well.
selected = sv[sv <= float(self.alpha) / n_features *
(np.arange(n_features) + 1)]
| @@ -597,7 +597,7 @@ def _get_support_mask(self): | |||
| n_features = len(self.pvalues_) | |||
| sv = np.sort(self.pvalues_) | |||
| selected = sv[sv <= float(self.alpha) / n_features | |||
| * np.arange(n_features)] | |||
| 8000 * (np.arange(n_features) + 1)] | |||
There was a problem hiding this comment.
shouldn't this be np.arange(1, n_features + 1)?
|
@anandjeyahar given the existing PR to fix this issue, and that it is a straightforward issue, would you mind closing it? |
Reference Issue
Fixes selectFDR bug #7474
What does this implement/fix? Explain your changes.
ANOVA selector is made more cleaner.
Any other comments?
This change is