10000 [MRG] CI build web site from branches by jnothman · Pull Request #7498 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG] CI build web site from branches #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2016

Conversation

jnothman
Copy link
Member

Fixes #7495.

I'm not sure how to check circleci is happy with this, but I think this is what you mean, @amueller.

@lesteve
Copy link
Member
lesteve commented Sep 27, 2016

circle.yml doesn't seem valid, here is the error from CircleCI:

Syntax Error while parsing circle.yml: while parsing a flow sequence in 'reader', line 16, column 12: branch: [master, /^[0-9]+.[0-9]+.X/] ^ expected ',' or ']', but got FlowSequenceStart in 'reader', line 16, column 23: branch: [master, /^[0-9]+.[0-9]+.X/] ^

@lesteve
Copy link
Member
lesteve commented Sep 27, 2016

Reading https://circleci.com/docs/configuration/#deployment, maybe this would work:

branch: /master|^[0-9]+\.[0-9]+\.X/

@amueller
Copy link
Member

Yeah that seems good. Not sure if there is a better way then testing, backporting and pushing a change?

@NelleV
Copy link
Member
NelleV commented Sep 28, 2016

I was wondering how you'd test this…

@amueller
Copy link
Member

I'm ok with merging as-is and seeing what happens ;)

@NelleV
Copy link
Member
NelleV commented Sep 28, 2016

Well, me too, but I'll let you click on the green button.

@jnothman
Copy link
Member Author

It can hardly hurt to push an empty commit onto 0.17.X...??

On 29 September 2016 at 05:35, Nelle Varoquaux notifications@github.com
wrote:

Well, me to, but I'll let you click on the green button.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7498 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6_NnW_TXxuwvBcZIXM_LzKebt0eAks5qusFngaJpZM4KHoeq
.

@amueller amueller merged commit 69ca580 into scikit-learn:master Sep 29, 2016
@amueller
Copy link
Member

@jnothman Actually I want to remove the "in development" in the whatsnew ;) lets see if that works!

amueller pushed a commit to amueller/scikit-learn that referenced this pull request Sep 29, 2016
* CI build web site from branches

Fixes scikit-learn#7495

* CI Try one regexp instead of list
@amueller
Copy link
Member

it worked! nice!

@jnothman
Copy link
Member Author

Yay!

On 30 September 2016 at 00:15, Andreas Mueller notifications@github.com
wrote:

it worked! nice!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7498 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz66pZoTczJB0MuU13kxVBXwxIp5VMks5qu8f-gaJpZM4KHoeq
.

@jnothman
Copy link
Member Author

Except that you should have replaced it with a date, rather than removing
it...

On 30 September 2016 at 12:55, Joel Nothman joel.nothman@gmail.com wrote:

Yay!

On 30 September 2016 at 00:15, Andreas Mueller notifications@github.com
wrote:

it worked! nice!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7498 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz66pZoTczJB0MuU13kxVBXwxIp5VMks5qu8f-gaJpZM4KHoeq
.

@amueller
Copy link
Member

whoops, sorry

TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
* CI build web site from branches

Fixes scikit-learn#7495

* CI Try one regexp instead of list
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
* CI build web site from branches

Fixes scikit-learn#7495

* CI Try one regexp instead of list
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
* CI build web site from branches

Fixes scikit-learn#7495

* CI Try one regexp instead of list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0