-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] CI build web site from branches #7498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
circle.yml doesn't seem valid, here is the error from CircleCI:
|
Reading https://circleci.com/docs/configuration/#deployment, maybe this would work:
|
Yeah that seems good. Not sure if there is a better way then testing, backporting and pushing a change? |
I was wondering how you'd test this… |
I'm ok with merging as-is and seeing what happens ;) |
Well, me too, but I'll let you click on the green button. |
It can hardly hurt to push an empty commit onto 0.17.X...?? On 29 September 2016 at 05:35, Nelle Varoquaux notifications@github.com
|
@jnothman Actually I want to remove the "in development" in the whatsnew ;) lets see if that works! |
* CI build web site from branches Fixes scikit-learn#7495 * CI Try one regexp instead of list
it worked! nice! |
Yay! On 30 September 2016 at 00:15, Andreas Mueller notifications@github.com
|
Except that you should have replaced it with a date, rather than removing On 30 September 2016 at 12:55, Joel Nothman joel.nothman@gmail.com wrote:
|
whoops, sorry |
* CI build web site from branches Fixes scikit-learn#7495 * CI Try one regexp instead of list
* CI build web site from branches Fixes scikit-learn#7495 * CI Try one regexp instead of list
* CI build web site from branches Fixes scikit-learn#7495 * CI Try one regexp instead of list
Fixes #7495.
I'm not sure how to check circleci is happy with this, but I think this is what you mean, @amueller.