[MRG + 1] MAINT Move heapify_up/heapify_down into PriorityHeap as class methods + COSMITs #7034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this still relevant and do you want reviews? |
|
it's relevant, but let's wait on reviews ;) this is just a place to put a bunch of misc changes. thanks for offering, though! |
+1 for that. Could you revive the PR and make travis pass? Thanks! |
91683fc to
0c38247
Compare
|
@raghavrv done, thanks for reminding me about this. |
raghavrv
reviewed
Oct 24, 2016
| @@ -240,6 +206,38 @@ cdef class PriorityHeap: | |||
| cdef bint is_empty(self) nogil: | |||
| return self.heap_ptr <= 0 | |||
|
|
|||
| cdef void heapify_up(self, PriorityHeapRecord* heap, SIZE_t pos) nogil: | |||
There was a problem hiding this comment.
Yeah, I originally moved it in because I made another priorityheap class for use with non-records, but we ended up deciding that was too slow. I do think it is cleaner, though.
|
gentle ping wrt this? |
<
8000
/tr>
|
+1 from me another review from @jmschrei? |
raghavrv
approved these changes
Dec 22, 2016
|
This looks fine to me, but I wouldn't mind a quick check from one of you tree loppers. |
|
I think a +1 from you will suffice :) Merging as most (other) tree loopers are quite bust atm and I've bigger PRs for them ;) |
sergeyf
pushed a commit
to sergeyf/scikit-learn
that referenced
this pull request
Feb 28, 2017
…ss methods + COSMITs (scikit-learn#7034) * RFC: move heap methods to class and remove trailing spaces * spurious comment to force recythonization of boosting * [ci skip] remove spurious comment * remove trailing whitespace on line * style: fix trailing whitespace in _criterion.pxd * add spurious comments to try to force recythonizing * remove changes for recythonization
Closed
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…ss methods + COSMITs (scikit-learn#7034) * RFC: move heap methods to class and remove trailing spaces * spurious comment to force recythonization of boosting * [ci skip] remove spurious comment * remove trailing whitespace on line * style: fix trailing whitespace in _criterion.pxd * add spurious comments to try to force recythonizing * remove changes for recythonization
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…ss methods + COSMITs (scikit-learn#7034) * RFC: move heap methods to class and remove trailing spaces * spurious comment to force recythonization of boosting * [ci skip] remove spurious comment * remove trailing whitespace on line * style: fix trailing whitespace in _criterion.pxd * add spurious comments to try to force recythonizing * remove changes for recythonization
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…ss methods + COSMITs (scikit-learn#7034) * RFC: move heap methods to class and remove trailing spaces * spurious comment to force recythonization of boosting * [ci skip] remove spurious comment * remove trailing whitespace on line * style: fix trailing whitespace in _criterion.pxd * add spurious comments to try to force recythonizing * remove changes for recythonization
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…ss methods + COSMITs (scikit-learn#7034) * RFC: move heap methods to class and remove trailing spaces * spurious comment to force recythonization of boosting * [ci skip] remove spurious comment * remove trailing whitespace on line * style: fix trailing whitespace in _criterion.pxd * add spurious comments to try to force recythonizing * remove changes for recythonization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen a lot of misc style / refactoring sort of issues while working on the tree code. Rather than clutter up other PRs with these changes, i figured that i would move them here.
What does this implement/fix? Explain your changes.
heapify_upandheapify_downmethods to be within thePriorityHeapstructure