[MRG] Fixes issue #6746 "number of power iterations" message #7010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes default value passed to extmath.py from pca.py to None.
|
Can you update the docs as well to reflect the new defaults? |
|
also i'm not sure that this is the way to go....might also want to check out http://scikit-learn.org/dev/developers/contributing.html#deprecation |
|
there are tests errors. And this shouldn't change any user behavior, apart from no warning. |
|
I'm pretty confused now. I would have left the explicit number here, and change the default to None in extmath. |
Fix issue scikit-learn#6746 What does this implement/fix? Explain your changes. * Change default value passed to extmath.py from pca.py to None. * update tests to reference the value of "None" being passed to extmath.py
Fixes issue scikit-learn#6746 What does this implement/fix? Explain your changes. Changes default value passed to extmath.py from pca.py to None.
Fix issue scikit-learn#6746 What does this implement/fix? Explain your changes. Changes default value passed to extmath.py from pca.py to None. Update Docs and Doc Tests to reflect new value
|
I still don't understand what's happening here... Shouldn't the changes be in the randomized svd function? |
Fix issue scikit-learn#6746 What does this implement/fix? Explain your changes. Changes default value passed to extmath.py from pca.py to None. Update Docs and Doc Tests in to reflect new value
|
@amueller the output from that function is referenced in a number of different doc tests, so the previously discussed changes required updates to the docs/ tests that referenced the default output of PCA. |
|
fixed by #7311. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes issue #6746
What does this implement/fix? Explain your changes.
[MRG+1] Disabled randomized_svd warning when number of iterations is no… #6749 addressed the default within extmath.py and added some checking for whether the "number of power iterations" message was needed but didn't address the value being passed from pca.py.