Skip k-means parallel test on Mac OS X Lion (10.7) #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug that occurs in the BLAS DGEMM function after a fork on Mac OS X Lion that causes this test to hang. See issue scikit-learn#636 for details. This commit causes the test_k_means_plus_plus_init_2_jobs test to be skipped on this platform. The Mac version is determined from platform.mac_ver() similar to how it is described in the following link. I couldn't find a 'cleaner' way. http://stackoverflow.com/questions/1777344/how-to-detect-mac-os-version-using-python
ogrisel
added a commit
that referenced
this pull request
Mar 14, 2012
Skip k-means parallel test on Mac OS X Lion (10.7)
|
Merged, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that occurs in the BLAS DGEMM function after a fork on
Mac OS X Lion that causes this test to hang. See issue #636 for details.
This commit causes the test_k_means_plus_plus_init_2_jobs test to be
skipped on this platform.
The Mac version is determined from platform.mac_ver() similar to how it
is described in the following link. I couldn't find a 'cleaner' way.
http://stackoverflow.com/questions/1777344/how-to-detect-mac-os-version-using-python