8000 [MRG+1] Circle CI - Explicitly install psutil while building docs by raghavrv · Pull Request #6897 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] Circle CI - Explicitly install psutil while building docs #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2016
Merged

[MRG+1] Circle CI - Explicitly install psutil while building docs #6897

merged 1 commit into from
Jun 16, 2016

Conversation

raghavrv
Copy link
Member

The current master fails on circle CI. This is an attempt to fix it.

Ping @ogrisel

@raghavrv raghavrv changed the title CI Install psutil Circle CI - Explicitly install psutil while building docs Jun 16, 2016
@tguillemot
Copy link
Contributor

LGTM

@raghavrv raghavrv changed the title Circle CI - Explicitly install psutil while building docs [MRG] Circle CI - Explicitly install psutil while building docs Jun 16, 2016
@raghavrv
Copy link
Member Author

thx!!

@raghavrv raghavrv changed the title [MRG] Circle CI - Explicitly install psutil while building docs [MRG+1] Circle CI - Explicitly install psutil while building docs Jun 16, 2016
@agramfort
Copy link
Member

merge when CIs are happy

@agramfort agramfort merged commit 7fea3ef into scikit-learn:master Jun 16, 2016
@agramfort
Copy link
Member

thx @raghavrv

@raghavrv raghavrv deleted the patch-1 branch June 16, 2016 13:06
@tguillemot tguillemot mentioned this pull request Jun 16, 2016
Closed
@tguillemot
Copy link
Contributor

Ok it seems that the problem is not solved: circle ci is still failing on master.
Your pull request as passed circle ci but not the merge.
@raghavrv @ogrisel Maybe, it's a problem of the circle cache files as we had before with travis ?

@lesteve
Copy link
Member
lesteve commented Jun 16, 2016

Your pull request as passed circle ci but not the merge.

If you look at https://circleci.com/gh/scikit-learn/scikit-learn/3839, that's because the build was skipped on CircleCI. There was a way to force building the doc with some keyword in the commit but I don't remember it off the top of my head. Just check build_tools/circle/check_build_doc.py and you'll find it.

On CircleCI you can restart the build with SSH access. Maybe worth trying to investigate more. The error does not make any sense to me. Things I would try blindly if I had to:

  • Downloading a more recent Miniconda (we are using the latest one in nilearn and joblib and never had a problem AFAICR)
  • Try conda install psutil and then conda install the_other_packages

@lesteve
Copy link
Member
lesteve commented Jun 17, 2016

I opened a PR to fix the CircleCI failure, see #6903. It seems like the CircleCI build is running fine now. It hasn't completed yet, but the install step went fine and it is running the examples right now.

olologin pushed a commit to olologin/scikit-learn that referenced this pull request Aug 24, 2016
@raghavrv @olologin
CI Install psutil (scikit-learn#6897)
26f805a
TomDLT pushed a commit to TomDLT/scikit-learn that referenced this pull request Oct 3, 2016
@raghavrv @TomDLT
CI Install psutil (scikit-learn#6897)
edbab8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raghavrv @tguillemot @agramfort @lesteve
0