Work on cross val and pipelines. #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to pipeline GridsearchCV, Give a meaningful scaling to the scores in GridsearchCV Store the scores in GridsearchCV
…ized as classifiers, if they contain a classifier.
and use clone in cross_val_func
|
the "iid" stuff look good. I have to play a bit with the Pipeline to see if it works as expected. I'll keep you posted. |
larsmans
referenced
this pull request
in larsmans/scikit-learn
Jul 15, 2011
Revised text classification chapter
larsmans
referenced
this pull request
in larsmans/scikit-learn
May 20, 2013
agramfort
added a commit
that referenced
this pull request
Jul 24, 2013
nitpick fixes, pep8 and fix math equations
jaquesgrobler
pushed a commit
to jaquesgrobler/scikit-learn
that referenced
this pull request
Jul 25, 2013
ENH added the fork me ribbon to the website
jnothman
referenced
this pull request
in jnothman/scikit-learn
Jan 10, 2015
Fix merge conflict with scikit-learn/master
prismdata
pushed a commit
to prismdata/scikit-learn
that referenced
this pull request
Oct 28, 2020
remove tk48 test
hongshaoyang
pushed a commit
to hongshaoyang/scikit-learn
that referenced
this pull request
Nov 10, 2020
…-update Resolving conflicts
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code review: I am interested in suggestions on how to make this code stink less, or criticism that finds problems or bugs with this code.
Enhancements
is something that will need to be revisited at some point.
are the number one person who wants iid=True to work well.
Bug fixes
Make clone work on pipelines
The clone code is fragile. I don't like it. The alternative is to add a '_clone' method to an object that would
enable to override the clone behavior. I think that we need to keep this option in mind (the con is that it
makes the estimator 'contract' heavier, the pro is that it makes this contract more explicit. I still think that we
need the clone behavior in order to cross validate.
Make sure that classifiers are indeed recognized as so even when wrapped in CV or Pipeline objects
I am very unhappy with this code (but I would still like it merged, because it gives a temporary solution).
It raises the issue of how to recognize a classifier from a regressor. Finding the duck-typing signature for
classifiers is partly the problem, because once we have found it, we need to find a good way to 'propagate' in
the case of nested objects, as this commit shows.