8000 [MRG+1] Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples by amueller · Pull Request #5721 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2015
Merged

[MRG+1] Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples #5721

merged 1 commit into from
Dec 11, 2015

Conversation

amueller
Copy link
Member
@amueller amueller commented Nov 4, 2015

No description provided.

@amueller amueller added this to the 0.17 milestone Nov 4, 2015
This was referenced Nov 4, 2015
Closed
Closed
@amueller amueller force-pushed the examples_deprecation_fixes branch from a73d8a6 to 6193a9b Compare November 4, 2015 22:11
@GaelVaroquaux GaelVaroquaux changed the title [MRG] Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples [MRG+1] Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples Nov 5, 2015
@GaelVaroquaux
Copy link
Member

LGTM. +1 for merge

@amueller amueller mentioned this pull request Nov 20, 2015
Merged
@raghavrv
Copy link
Member

Does this fix #5716?

@amueller
Copy link
Member Author
amueller commented Dec 8, 2015

@rvraghav93 yes

@amueller amueller force-pushed the examples_deprecation_fixes branch from 6193a9b to 5b1aca0 Compare December 10, 2015 17:12
@amueller
Copy link
Member Author

ping @agramfort ;)

agramfort
agramfort reviewed Dec 10, 2015
View reviewed changes
examples/manifold/plot_compare_methods.py
@@ -113,7 +113,7 @@
Y = tsne.fit_transform(X)
t1 = time()
print("t-SNE: %.2g sec" % (t1 - t0))
ax = fig.add_subplot(250)
ax = fig.add_subplot(2, 5, 10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about the 10 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. they deprecated the previous syntax because it was real weird ;)

@agramfort
Copy link
Member

besides +1 for merge

agramfort added a commit that referenced this pull request Dec 11, 2015
@agramfort
Merge pull request #5721 from amueller/examples_deprecation_fixes
ff1ca88 
[MRG+1]  Don't use deprecated 1d X (or deprecated matplotlib stuff) in examples
@agramfort agramfort merged commit ff1ca88 into scikit-learn:master Dec 11, 2015
@agramfort
Copy link
Member

thanks @amueller

@amueller amueller mentioned this pull request Jan 20, 2016
Merged
@ogrisel
Copy link
Member
ogrisel commented Jan 27, 2016

This has already been backported to 0.17.X apparently.

@amueller amueller deleted the examples_deprecation_fixes branch May 19, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Blocker Waiting for Reviewer
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
5 participants
@amueller @GaelVaroquaux @raghavrv @agramfort @ogrisel
0