8000 Added colorblind compatibility for (unsorted) examples by johannah · Pull Request #5575 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

Added colorblind compatibility for (unsorted) examples #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2015

Conversation

johannah
Copy link
Contributor

Colorblind compatibility as discussed in #5435.

covariance/plot_lw_vs_oas.py
figure_1

covariance/plot_robust_vs_empirical_covariance.py
Made lines thicker and fixed (I think) reference.
figure_1

gaussian_process/plot_compare_gpr_krr.py
figure_1

manifold/plot_mds.py
figure_1

preprocessing/plot_function_transformer.py
figure_1
figure_2

semi_supervised/plot_label_propagation_structure.py
figure_1

@johannah johannah force-pushed the module-other-colorblind branch from 5877cac to 245c956 Compare October 23, 2015 17:44
@jmschrei
Copy link
Member

Should the last plot be "outer labeled" and "inner labeled" instead of both dots being "outer labeled"?

@johannah
Copy link
Contributor Author

Good catch - fixed it!

@johannah johannah force-pushed the module-other-colorblind branch from 245c956 to d15f322 Compare October 23, 2015 17:48
@jmschrei
Copy link
Member

This LGTM then.

@glouppe
Copy link
Contributor
glouppe commented Oct 25, 2015

LGTM too, merging.

glouppe added a commit that referenced this pull request Oct 25, 2015
Added colorblind compatibility for (unsorted) examples
@glouppe glouppe merged commit 07c8c58 into scikit-learn:master Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0