Added colorblind compatibility for decomposition example #5574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM ! |
8639f80 to
b980117
Compare
|
LGTM as well, assuming all checks pass. |
| @@ -40,11 +40,14 @@ | |||
| pca = PCA(n_components=n_components) | |||
| X_pca = pca.fit_transform(X) | |||
|
|
|||
| colors = ['navy', 'turquoise', 'darkorange'] | |||
| lw = 2 | |||
There was a problem hiding this comment.
It's a somewhat minor comment, but I would rather avoir adding a variable for something that is used only once. In other words, I would prefer if this value was just inlined in the call to "scatter".
b980117 to
0c29002
Compare
|
The circle ci failure is unrelated (network failure). Merging. |
ogrisel
added a commit
that referenced
this pull request
Oct 28, 2015
Added colorblind compatibility for decomposition example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colorblind compatibility as discussed in #5435.
plot_incremental_pca.py
plot_pca_vs_lda.py
plot_sparse_coding.py
