8000 [MRG] Fixed warnings for DataDimensionalityWarning and decision function by amueller · Pull Request #5395 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Fixed warnings for DataDimensionalityWarning and decision function #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2015
Merged

[MRG] Fixed warnings for DataDimensionalityWarning and decision function #5395

merged 1 commit into from
Oct 15, 2015

Conversation

amueller
Copy link
Member

Continuation / rebase of #5277 with some fixes.
Closes some of #5089.
Thanks @hasancansaral

@amueller amueller added this to the 0.17 milestone Oct 13, 2015
@amueller amueller changed the title Fixed warnings for DataDimensionalityWarning and decision function [MRG] Fixed warnings for DataDimensionalityWarning and decision function Oct 13, 2015
@MechCoder
Copy link
Member

ignore_warnings -> assert_warns ? (following @jnothman 's advice)

@amueller amueller force-pushed the some_test_deprecation_warnings branch from a25aa88 to 31a5a5f Compare October 14, 2015 19:38
@amueller
Copy link
Member Author

I did it for Lars.decision_function. Not sure it makes sense for the LSHForest.

@ogrisel
Copy link
Member
ogrisel commented Oct 15, 2015

It's good to silence such warnings so merging this PR. However for the future it would be better to explain which warning is silenced in tests and why in inline comments.

ogrisel added a commit that referenced this pull request Oct 15, 2015
@ogrisel
Merge pull request #5395 from amueller/some_test_deprecation_warnings
1070e1b 
[MRG] Fixed warnings for DataDimensionalityWarning and decision function
@ogrisel ogrisel merged commit 1070e1b into scikit-learn:master Oct 15, 2015
@amueller amueller mentioned this pull request Oct 15, 2015
Closed
@amueller
Copy link
Member Author

You're right. Though I actually only silenced warnings in the LSHForest, where the reason probably is "the parameters are not appropriate for the test data"

@amueller amueller deleted the some_test_deprecation_warnings branch May 19, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@amueller @MechCoder @ogrisel
0