8000 [MRG+1] Updated whatsnew for sprint and LatentDirichletAllocation by amueller · Pull Request #5236 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG+1] Updated whatsnew for sprint and LatentDirichletAllocation #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amueller
Copy link
Member
@amueller amueller commented Sep 9, 2015

Fixes #5191.
I didn't add whatsnew entries for minor example and doc changes.
I added links to the pull requests when appropriate, I think that will be helpful. wdyt?

@amueller
Copy link
Member Author
amueller commented Sep 9, 2015

pr_links

@amueller amueller changed the title Updated whatsnew for sprint and LatentDirichletAllocation [MRG] Updated whatsnew for sprint and LatentDirichletAllocation Sep 10, 2015
@ogrisel
Copy link
Member
ogrisel commented Sep 10, 2015

LGTM but this needs a rebase (again :). Do we want to put links to PR from now on?

@ogrisel ogrisel changed the title [MRG] Updated whatsnew for sprint and LatentDirichletAllocation [MRG+1] Updated whatsnew for sprint and LatentDirichletAllocation Sep 10, 2015
@amueller
Copy link
Member Author

I think it might be helpful and it is not that much work. Other projects do it. It was just a suggestion, though ;)

@ogrisel
Copy link
Member
ogrisel commented Sep 10, 2015

LGTM.

@amueller
Copy link
Member Author

merged as 6942043

@amueller amueller closed this Sep 10, 2015
@amueller amueller deleted the whatsnew_fixes branch May 19, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0