[MRG + 1] Bug fix for unnormalized laplacian #4995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, _set_diag() always set the diagonal of the Laplacian to 1. This is only valid for the normalized Laplacian. For the unnormalized Laplacian, the diagonal should not be changed.
|
can you add a test? |
|
I added a test that checks w.r.t. manual dense eigendecomposition. I don't know if that's sufficient. |
|
LGTM |
|
please add an entry to whatsnew.rst |
added information for this bugfix
…into patch-1 Conflicts: doc/whats_new.rst
|
I added the entry to whatsnew.rst and pulled all the changes from scikit-master, such that merging should be possible. |
|
Thanks. We need another review, though. |
So far, _set_diag() always set the diagonal of the Laplacian to 1. This is only valid for the normalized Laplacian. For the unnormalized Laplacian, the diagonal should not be changed.
added information for this bugfix
This reverts commit b97e5b4.
…o patch-1 Conflicts: doc/whats_new.rst
…into patch-1 Conflicts: doc/whats_new.rst
|
@amueller rebase is done. |
|
LGTM. Merging without appveyor, as it is drowning from the sprint. |
GaelVaroquaux
added a commit
that referenced
this pull request
Oct 19, 2015
[MRG + 1] Bug fix for unnormalized laplacian
Merged
|
+1 for focusing on regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, _set_diag() always set the diagonal of the Laplacian to 1. This is only valid for the normalized Laplacian. For the unnormalized Laplacian, the diagonal should not be changed.