10000 [MRG + 1] [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0 by trevorstephens · Pull Request #4422 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG + 1] [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0 #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2015
Merged

[MRG + 1] [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0 #4422

merged 1 commit into from
Mar 23, 2015

Conversation

trevorstephens
Copy link
Contributor

fixes #4399

@amueller

Also, should I also update y_numeric for https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/kernel_ridge.py#L144 and https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/stochastic_gradient.py#L868 ? Both are explicitly regressors. There's a couple others that share fit between classifiers and regressors too: gbm, adaboost, bagging... with no y_numeric=True on check_X_y.

Presumably all of the above get through tests because no call to the offending numpy function though...

Can confirm all tests pass locally on this branch, and 2 fails on an up to date master, with np 1.8.0 installed on python 2.7.9, ubuntu 14.04. :feelsgood:

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 09e6e12 on trevorstephens:y_numeric_for_np180 into bc5acea on scikit-learn:master.

@amueller
Copy link
Member

lol @ emoji :)
I think if the tests pass it means everything gets handled correctly, even if y_numeric is not passed.
I just want to avoid breaking tests on 0.1.8

@amueller amueller changed the title [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0 [MRG + 1] [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0 Mar 20, 2015
@amueller amueller added the Bug label Mar 20, 2015
@amueller amueller added this to the 0.16 milestone Mar 20, 2015
@amueller
Copy link
Member

ping @ogrisel this needs a backport or tests will fail on numpy 1.8.0 and 1.8.0rc1

@ogrisel
Copy link
Member
ogrisel commented Mar 23, 2015

LGTM, thanks @trevorstephens for the extensive platform-dependent hunt and fix. Will do the merge and backport to 0.16.X.

ogrisel added a commit that referenced this pull request Mar 23, 2015
@ogrisel
Merge pull request #4422 from trevorstephens/y_numeric_for_np180
ad26ae4 
[MRG + 1] [FIX] LarsCV and LassoLarsCV fails for numpy 1.8.0
@ogrisel ogrisel merged commit ad26ae4 into scikit-learn:master Mar 23, 2015
@trevorstephens trevorstephens deleted the y_numeric_for_np180 branch March 23, 2015 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

Test fails in least_angle on master
4 participants
@trevorstephens @landscape-bot @amueller @ogrisel
0