[MRG + 1] FIX Include PyFuncDistance attributes while pickling. #4362

raghavrv · 2015-03-09T00:27:16Z

GaelVaroquaux · 2015-03-09T07:17:54Z

raghavrv · 2015-03-09T20:21:17Z

amueller · 2015-03-09T22:36:14Z

sklearn/neighbors/tests/test_ball_tree.py


    def check_pickle_protocol(protocol):
        s = pickle.dumps(bt1, protocol=protocol)
        bt2 = pickle.loads(s)
+
+        s_pyfunc = pickle.dumps(bt1_pyfunc, protocol=protocol)
+        bt2_pyfunc = pickle.loads(s_pyfunc)


did that fail on master?

Yes! but this particular line will pass, querying alone will fail. (new line #+242)

coveralls · 2015-03-18T21:52:12Z

raghavrv · 2015-03-23T23:43:42Z

raghavrv · 2015-04-27T10:21:06Z

amueller · 2015-04-29T21:41:48Z

ogrisel · 2015-05-22T09:50:15Z

raghavrv changed the title ~~FIX Include PyFuncDistance attributes while pickling.~~ [WIP] FIX Include PyFuncDistance attributes while pickling. Mar 9, 2015

raghavrv changed the title ~~[WIP] FIX Include PyFuncDistance attributes while pickling.~~ [MRG] FIX Include PyFuncDistance attributes while pickling. Mar 9, 2015

amueller reviewed Mar 9, 2015
View reviewed changes

raghavrv force-pushed the make_PyFuncDistance_picklable branch from e583cef to 2e982ce Compare March 18, 2015 20:44

raghavrv force-pushed the make_PyFuncDistance_picklable branch from 2e982ce to dd043be Compare April 27, 2015 10:21

amueller changed the title ~~[MRG] FIX Include PyFuncDistance attributes while pickling.~~ [MRG + 1] FIX Include PyFuncDistance attributes while pickling. Apr 29, 2015

raghavrv force-pushed the make_PyFuncDistance_picklable branch 2 times, most recently from 0c3ae8c to d9284aa Compare May 3, 2015 19:04

raghavrv added 3 commits May 6, 2015 05:48

FIX Include PyFuncDistance attributes while pickling.

190fe73

TST Add test to make sure BallTree remains picklable even with callab…

d3fba99

…le metric

8000

TST make sure DistMetric is picklable with both predefined as well as…

a685fe5

… custom metric

raghavrv force-pushed the make_PyFuncDistance_picklable branch from d9284aa to a685fe5 Compare May 6, 2015 00:18

amueller mentioned this pull request May 8, 2015

Unable to Serialize and Deserialize Model with customized distance function #4360

Closed

ogrisel added a commit that referenced this pull request May 22, 2015

Merge pull request #4362 from rvraghav93/make_PyFuncDistance_picklable

3af811e

[MRG + 1] FIX Include PyFuncDistance attributes while pickling.

ogrisel merged commit 3af811e into scikit-learn:master May 22, 2015

raghavrv deleted the make_PyFuncDistance_picklable branch February 11, 2016 13:13

ryan-deak-zefr mentioned this pull request Mar 11, 2019

Weighted scoring in cross validation (Closes #4632) #13432

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG + 1] FIX Include PyFuncDistance attributes while pickling. #4362

[MRG + 1] FIX Include PyFuncDistance attributes while pickling. #4362

[MRG + 1] FIX Include PyFuncDistance attributes while pickling. #4362

[MRG + 1] FIX Include PyFuncDistance attributes while pickling. #4362

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment