8000 improvements to k-means (and one PCA thing) by jaberg · Pull Request #42 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

improvements to k-means (and one PCA thing) #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
19 commits merged into from
Jan 14, 2011
Merged

improvements to k-means (and one PCA thing) #42

19 commits merged into from
Jan 14, 2011

Conversation

jaberg
Copy link
Contributor
@jaberg jaberg commented Jan 12, 2011

Thanks for the feedback from the pull request I sent this afternoon - I made those changes and more, hopefully you like this set better.

jaberg added 14 commits January 10, 2011 13:10
@jaberg
k_means_ - added optional rng parameter to work routines
1cb7799
@jaberg
Centering data for k-means before fitting
5b9605e
@jaberg
k-means - added verbose-level print after initialization
c182b37
@jaberg
added faster distance-computation algorithm to k-means _e_step
d0084d7
@jaberg
PCA train() stores eigenvalues associated with components
5fcbbbf
@jaberg
adding James Bergstra as author of k_means_ file
a5af706
@jaberg
k-means adding all_paris_l2_distance_squared function
1563c31
@jaberg
k-means - modified k_init to use pre-computed distances for faster, c…
73c6024 
…learer code
@jaberg
k-means - added support for a callable "init" argument instead of cop…
e66a033 
…ying all the k_init parameters as optional arguments - invite user to use a lambda or something
@jaberg
k-means - fixed misleading typo in error message
38bd96e
@jaberg
k-means - added optional parameters "precompute_distances" and "x_squ…
9242e46 
…ared_norms"
@jaberg
k-means - added "verbose" parameter to KMeans class
21122d7
@jaberg
k-means - added copy_x parameter to worker routine and BaseEstimator,…
c2e17ac 
… allowing optional in-place operation
@jaberg
added optional args to euclidean_distances and removed k_means_.all_p…
e7929e6 
…airs_l2_distances_squared
@jaberg
Copy link
Contributor Author
jaberg commented Jan 13, 2011

@alex - I have made the formatting changes you suggested, and modified k-means to use the euclidean_distances function rather than the local function I had written for that. To keep the same level of speed though, I added a two new optional arguments to the euclidean_distances function. What do you think?

@ogrisel
Copy link
Member
ogrisel commented Jan 14, 2011

I did some more PEP8 cosmits and merged it to master. Thank you all :)

jnothman pushed a commit to jnothman/scikit-learn that referenced this pull request Nov 20, 2016
@rgommers
Merge pull request scikit-learn#42 from androomerrill/docscrape-bugfix
7ad04bf 
BUG: restore support for Python 3.4.
@qinhanmin2014 qinhanmin2014 mentioned this pull request Nov 6, 2017
Closed
@ZHCSOFT ZHCSOFT mentioned this pull request Mar 10, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaberg @ogrisel @agramfort @GaelVaroquaux
0