8000 [MRG] Fix gamma update in DPGMM by amueller · Pull Request #4175 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Fix gamma update in DPGMM #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MRG] Fix gamma update in DPGMM #4175

wants to merge 1 commit into from

Conversation

amueller
Copy link
Member

Fixes #1764.
Tests don't change, I have no idea how to test for this.
In the light of #2454 it seems unlikely we can currently test for this in a sensible way.

@amueller amueller added the Bug label Feb 14, 2015
@amueller amueller added this to the 0.16 milestone Feb 14, 2015
@ogrisel
Copy link
Member
ogrisel commented Feb 19, 2015

By trying to understand this code I realised that the gamma_ attribute is not documented in the class docstring. Neither for DPGMM nor VBGMM.

@amueller
Copy link
Member Author

I am pretty sure the whole thing needs a reimplementation anyhow.

@amueller
Copy link
Member Author

Still, I'd like to fix as many obvious bugs as possible.
8000

@amueller amueller modified the milestones: 0.16, 0.17 Sep 11, 2015
@amueller
Copy link
Member Author

closing in favor of #4802

@amueller amueller closed this Sep 20, 2015
@ogrisel ogrisel modified the milestones: 0.18, 0.17 Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.

[DPGMM - _update_concentrations fail implementation]
2 participants
@amueller @ogrisel
0