8000 [WIP]Parameters moved from fit to the constructor by akshayah3 · Pull Request #4112 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[WIP]Parameters moved from fit to the constructor #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP]Parameters moved from fit to the constructor #4112

wants to merge 1 commit into from

Conversation

akshayah3
Copy link
Contributor

Fixes #4107

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling d00a9d8 on akshayah3:init into 7962412 on scikit-learn:master.

amueller
amueller reviewed Jan 17, 2015
View reviewed changes
sklearn/qda.py
@@ -100,6 +110,22 @@ def fit(self, X, y, store_covariances=False, tol=1.0e-4):
tol : float, optional, default 1.0e-4
Threshold used for rank estimation.
"""
if store_covariances:
warnings.warn("The store_covariances parameter in fit is deprecated"
"and will be removed in 0.17. It has been moved from"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.18 unfortunately.

@amueller
Copy link
Member

The parameters should be set to None and if they are not None it should be warned. The way it is done is an error in LDA (which you can feel free to fix).
The issue is that if someone passes tol=1e-4 it'll pass without warning and then break once the parameter is removed.

@trevorstephens trevorstephens mentioned this pull request Jan 17, 2015
Closed
@trevorstephens trevorstephens mentioned this pull request Sep 22, 2015
Merged
@amueller amueller closed this Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move all data-independent fit-params to __init__.
3 participants
@akshayah3 @coveralls @amueller
0