8000 [MRG+1] FIX Use slinear interpolation for isotonic regression by raghavrv · Pull Request #4111 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] FIX Use slinear interpolation for isotonic regression #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2015
Merged

[MRG+1] FIX Use slinear interpolation for isotonic regression #4111

merged 1 commit into from
Jan 17, 2015

Conversation

raghavrv
Copy link
Member

Fixes #4101

@agramfort
Copy link
Member

+1 for merge

@raghavrv raghavrv changed the title FIX Use slinear interpolation for isotonic regression [MRG+1] FIX Use slinear interpolation for isotonic regression Jan 17, 2015
@GaelVaroquaux
Copy link
Member

LGTML. Merging.

GaelVaroquaux added a commit that referenced this pull request Jan 17, 2015
@GaelVaroquaux
Merge pull request #4111 from ragv/slinear_isotonic
7962412 
[MRG+1] FIX Use slinear interpolation for isotonic regression
@GaelVaroquaux GaelVaroquaux merged commit 7962412 into scikit-learn:master Jan 17, 2015
@raghavrv raghavrv deleted the slinear_isotonic branch January 17, 2015 13:20
jmetzen
jmetzen reviewed Jan 17, 2015
View reviewed changes
sklearn/isotonic.py
@@ -228,7 +228,7 @@ def _build_f(self, X, y):
.format(self.out_of_bounds))

bounds_error = self.out_of_bounds == "raise"
self.f_ = interpolate.interp1d(X, y, kind='linear',
self.f_ = interpolate.interp1d(X, y, kind='slinear',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can (and should) now also undo the workaround in line 321, i.e., adding np.finfo(float).resolution to self.X_min_, and remove the comment in 319-320

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fixed in #4113...

@ogrisel ogrisel mentioned this pull request Feb 4, 2015
Closed
5 tasks
@ogrisel ogrisel mentioned this pull request Feb 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use slinear interpolation in Isotonic
4 participants
@raghavrv @agramfort @GaelVaroquaux @jmetzen
0