8000 [MRG] Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min by MechCoder · Pull Request #3811 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG] Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2014
Merged

[MRG] Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min #3811

merged 1 commit into from
Oct 29, 2014

Conversation

MechCoder
Copy link
Member

Fixes #3807

I am able to bring the time down from 313s as seen in this gist (https://gist.github.com/MechCoder/8342cec755d167cc7cad) to 249s as seen in this gist (https://gist.github.com/MechCoder/6c29efb33917c5d97857)

@MechCoder MechCoder changed the title Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min [MRG] Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min Oct 29, 2014
@MechCoder
Copy link
Member Author
MechCoder com 8000 mented Oct 29, 2014

The time in check_pairwise_arrays is brought down from 70s to 1s. ping @agramfort @larsmans

@MechCoder MechCoder force-pushed the fix_repeated_checking branch from 045d928 to 0357479 Compare October 29, 2014 14:13
@agramfort
Copy link
Member

do you change any existing behavior?

@MechCoder
Copy link
Member Author

Give me five minutes, I shall make changes to make it backward compatible.

@MechCoder MechCoder force-pushed the fix_repeated_checking branch 3 times, most recently from 560f7f6 to 864154e Compare October 29, 2014 15:15
@MechCoder
Copy link
Member Author

I squashed everything to one commit. I think it should be backward compatible now. @agramfort can you have a look? I'll just for speed regressions once more.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 864154e on MechCoder:fix_repeated_checking into 626f672 on scikit-learn:master.

@MechCoder
Copy link
Member Author

This PR cuts around (1/3 rd of the time) that is from 320s to 220s. @GaelVaroquaux might also be interested.

@MechCoder MechCoder force-pushed the fix_repeated_checking branch from 864154e to b500e3e Compare October 29, 2014 16:25
@MechCoder
Copy link
Member Author

@agramfort done

agramfort added a commit that referenced this pull request Oct 29, 2014
@agramfort
Merge pull request #3811 from MechCoder/fix_repeated_checking
3f49cee 
[MRG] Fix repeated calls of check_pairwise and type casting in pairwise_distances_argmin_min
@agramfort agramfort merged commit 3f49cee into scikit-learn:master Oct 29, 2014
@agramfort
Copy link
Member

thanks @MechCoder !

@MechCoder MechCoder deleted the fix_repeated_checking branch October 29, 2014 16:48
@MechCoder MechCoder mentioned this pull request Nov 19, 2014
Merged
5 tasks
@MechCoder MechCoder mentioned this pull request Dec 12, 2014
Merged
@larsmans larsmans mentioned this pull request Dec 12, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent repeated checking and typecasting in check_pairwise
3 participants
@MechCoder @agramfort @coveralls
0