8000 [MRG+1] Added macro-average ROC to plot_roc.py by wangz10 · Pull Request #3651 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] Added macro-average ROC to plot_roc.py #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 30, 2015
Merged

[MRG+1] Added macro-average ROC to plot_roc.py #3651

merged 5 commits into from
Aug 30, 2015

Conversation

@wangz10
Copy link
Contributor
@wangz10 wangz10 commented Sep 9, 2014

I added macro-average ROC to plot_roc.py

Macro-averaging is also an important performance measure used in multi-label classification.

@jnothman
Copy link
Member
jnothman commented Sep 10, 2014

Could you please rebase your work on master? (Currently you have committed on top of a May 2014 version of the repository.)

@jnothman
Copy link
Member
jnothman commented Sep 10, 2014

I should note: The file has moved to examples/model_selection

@coveralls
Copy link
coveralls commented Sep 10, 2014

Coverage Status

Changes Unknown when pulling 8cee66b on wangz10:master into * on scikit-learn:master*.

@coveralls
Copy link
coveralls commented Sep 12, 2014

Coverage Status

Changes Unknown when pulling 3bf6975 on wangz10:master into * on scikit-learn:master*.

jnothman
jnothman reviewed Sep 13, 2014
View reviewed changes
examples/model_selection/plot_roc.py
Copy link
Member
@jnothman jnothman Sep 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This insertion is duplicated.

@jnothman
Copy link
Member
jnothman commented Sep 13, 2014

Apart from those minor points, LGTM

@coveralls
Copy link
coveralls commented Sep 13, 2014

Coverage Status

Changes Unknown when pulling 9c079cf on wangz10:master into * on scikit-learn:master*.

@jnothman jnothman changed the title Added macro-average ROC to plot_roc.py [MRG+1] Added macro-average ROC to plot_roc.py Sep 13, 2014
@jnothman
Copy link
Member
jnothman commented Oct 2, 2014

Note that I have seen macro-averaging in early papers about using AUROC in a multiclass setting, so I'm +1 that it be shown, as well as +1 for the code.

@GaelVaroquaux GaelVaroquaux merged commit 9c079cf into scikit-learn:master Aug 30, 2015
@GaelVaroquaux
Copy link
Member
GaelVaroquaux commented Aug 30, 2015

Merged. Thanks (and sorry for the long turn around).

@jnothman jnothman mentioned this pull request Sep 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

4E43 No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangz10 @jnothman @coveralls @GaelVaroquaux
0