10000 Bugfixes in gaussian_process subpackage (continued) by jmetzen · Pull Request #3545 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Bugfixes in gaussian_process subpackage (continued) #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Bugfixes in gaussian_process subpackage (continued) #3545

wants to merge 4 commits into from

Conversation

jmetzen
Copy link
Member
@jmetzen jmetzen commented Aug 10, 2014

This is a continuation of the inactive PR #2632, which fixed two issues in the gaussian_process package:

  • Optimum theta over multiple random-starts was not determined correctly
  • gp_diabetes_dataset.py crashed because it tried to access gp.theta rather than gp.theta_

Credit for these fixes goes to @dubourg. The fixes have already been reviewed by @agramfort, @jaquesgrobler, and @GaelVaroquaux. The only thing missing was a regression test, which I add in this PR (sorry for a new PR, but the old one is apparently inactive and I can not work on it). Furthermore, I removed a call to scipy.rand in GaussianProcess which resulted in inconsistent results for the same random_state.

I hope that this is sufficient for gettin 8000 g this PR merged soon.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 9b08093 on jmetzen:bugfix-gp-random_start into acac25d on scikit-learn:master.

@larsmans larsmans closed this in c604ac3 Aug 11, 2014
@larsmans
Copy link
Member

Merged with a tiny cosmetic fix (extra blank line), thanks!

@kastnerkyle
Copy link
Member

Glad to see this got merged!

@jmetzen
Copy link
Member Author
jmetzen commented Aug 13, 2014

Thanks for merging!

@jmetzen jmetzen mentioned this pull request Aug 30, 2014
Closed
@jmetzen jmetzen deleted the bugfix-gp-random_start branch September 15, 2014 14:10
IssamLaradji pushed a commit to IssamLaradji/scikit-learn that referenced this pull request Oct 13, 2014
@larsmans @IssamLaradji
Merge branch 'pr/3545'
b0d832e 
Fixes scikit-learn#3545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmetzen @coveralls @larsmans @kastnerkyle @dubourg
0