8000 [MRG+1] DOC A less-nested coverage of model evaluation by jnothman · Pull Request #3527 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

[MRG+1] DOC A less-nested coverage of model evaluation #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2014
Merged

[MRG+1] DOC A less-nested coverage of model evaluation #3527

merged 1 commit into from
Aug 5, 2014

Conversation

jnothman
Copy link
Member
@jnothman jnothman commented Aug 4, 2014

http://scikit-learn.org/stable/modules/model_evaluation.html has a section numbered 3.5.2.1.6.2. This is bad.

This PR increases readability by removing a level of nesting. It makes classification metrics, etc. top-level sections on the page.

@arjoly
Copy link
Member
arjoly commented Aug 4, 2014

+1 the travis failure seems unrelated.

@jnothman
Copy link
Member Author
jnothman commented Aug 4, 2014

the travis failure seems unrelated.

It's been around a couple of days, and is a heisenbug on my own system, as noted here

@jnothman jnothman changed the title DOC A less-nested coverage of model evaluation [MRG+1] DOC A less-nested coverage of model evaluation Aug 4, 2014
@jnothman
Copy link
Member Author
jnothman commented Aug 5, 2014

As this is far from controversial, I will merge.

jnothman added a commit that referenced this pull request Aug 5, 2014
@jnothman
Merge pull request #3527 from jnothman/unnest-model-evaluation
22cafa6 
[MRG] DOC A less-nested coverage of model evaluation
@jnothman jnothman merged commit 22cafa6 into scikit-learn:master Aug 5, 2014
@arjoly
Copy link
Member
arjoly commented Aug 5, 2014

Thanks!

IssamLaradji pushed a commit to IssamLaradji/scikit-learn that referenced this pull request Oct 13, 2014
@jnothman @IssamLaradji
Merge pull request scikit-learn#3527 from jnothman/unnest-model-evalu…
ff89144 
…ation

[MRG] DOC A less-nested coverage of model evaluation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnothman @arjoly
0