Remove duplicate GaussianNB.fit() code #3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is substantially duplicated by partial_fit(), so just call partial_fit().
| @@ -235,7 +215,7 @@ def _update_mean_variance(n_past, mu, var, X): | |||
|
|
|||
| return total_sum / n_total, total_ssd / n_total | |||
|
|
|||
| def partial_fit(self, X, y, classes=None): | |||
| def partial_fit(self, X, y, classes=None, _refit=False): | |||
There was a problem hiding this comment.
adding such a param is not ok. The API shall stay clean. You might rely a private _partial_fit method.
|
OK, preserved API using your suggestion in d709833. |
| Must be provided at the first call to partial_fit, can be omitted | ||
| in subsequent calls. | ||
|
|
||
| _refit: boolean |
|
8000
LGTM if travis is happy |
agramfort
added a commit
that referenced
this pull request
Jul 5, 2014
Remove duplicate GaussianNB.fit() code
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #3324.
GaussianNB.fitis substantially duplicated bypartial_fit, and the latter is more flexible, so just have the former call the latter. There should be no significant degradation in performance or numerical stability, since the mean/variance update will just callnumpy.meanandnumpy.varwhenn_past == 0rather than trying anything fancy.