8000 Docs: Add Nvidia RAPIDS by smith558 · Pull Request #31682 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Docs: Add Nvidia RAPIDS #31682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Add Nvidia RAPIDS #31682

wants to merge 1 commit into from
+4 −0
8000

Conversation

smith558
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Add Nvidia RAPIDS

Any other comments?

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 92afcee. Link to the linter CI: here

virchan
virchan reviewed Jun 30, 2025
View reviewed changes
Copy link
Member
@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @smith558!

@adrinjalali, just a friendly ping, do you think NVIDIA RAPIDS would be appropriate to include on the "Related Projects" page?

@ogrisel
Copy link
Member
ogrisel commented Jul 2, 2025

+1 for referencing RAPIDS in that section, but the disclaimer for the scikit-learn-intelex item should be extracted as a new paragraph at the beginning of the "Model throughput" section because it would apply for both projects.

@adrinjalali
Copy link
Member

I'm not sure about this one. Should it not instead be the cuml project?

@smith558
Copy link
Contributor Author
smith558 commented Jul 2, 2025

I'm not sure about this one. Should it not instead be the cuml project?

Indeed. It is cuML. But cuML is a part of RAPIDS. Not a separate project.

@adrinjalali
Copy link
Member

Indeed. It is cuML. But cuML is a part of RAPIDS. Not a separate project.

And intelex is a part of intel, that doesn't mean we refer to intel as a related project 😅

From the perspective of our users, and us, cuML is a separate project, separate repo, separate pypi package. It's as if you reference PyData packages or include numpy/scipy/scikit-learn all as the same "project".

@smith558
Copy link
Contributor Author
smith558 commented Jul 2, 2025 •
edited
Loading

And intelex is a part of intel, that doesn't mean we refer to intel as a related project 😅

Sorry, the project is literally called RAPIDS, it's the preferred way of the maintainers. When were we discussing the word "Nvidia"? My comment said:

Indeed. It is cuML. But cuML is a part of RAPIDS. Not a separate project.

I am happy for you to drop "Nvidia". (Even though I think it makes sense to keep "Nvidia" in it, because it's strictly only for Nvidia chips.)

And intelex is a part of intel, that doesn't mean we refer to intel as a related project 😅

No, you do. In the docs you literally call intelex "Intel(R) Extension for scikit-learn". (as shown below)

image

@adrinjalali
Copy link
Member

I'd be okay with including cuML as the main item, but mentioning it's a part of the RAPIDS ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virchan virchan virchan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smith558 @ogrisel @adrinjalali @virchan
0