8000 DOC: Add link to plot_ensemble_oob example by Ganasekhar-gif · Pull Request #31457 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC: Add link to plot_ensemble_oob example #31457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Ganasekhar-gif
Copy link

Reference Issues/PRs
Towards #30621

What does this implement/fix? Explain your changes.
-Added description to the API documentation in sklearn.ensemble.RandomForestClassifier

Copy link
github-actions bot commented May 30, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: eef6098. Link to the linter CI: here

Copy link
Member
@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @Ganasekhar-gif!

I have a few comments.

Comment on lines 1189 to 1190
For an illustration of out-of-bag (OOB) error estimation, see the example
:ref:`sphx_glr_auto_examples_ensemble_plot_ensemble_oob.py`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better placed under the oob_score parameter in the docstring of RandomForestClassifier.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure i will make a new commit with this change

Copy link
Member
@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the PR, @Ganasekhar-gif! I have a few more comments.

It'd be a good idea to include the example link in the docstrings of RandomForestRegressor, ExtraTreesRegressor, and ExtraTreesClassifier.

…, ExtraTreesClassifier and ExtraTreesRegressor docstring
@Ganasekhar-gif
Copy link
Author

Hi @virchan! I've added references to the plot_ensemble_oob example in the docstrings of RandomForestRegressor, ExtraTreesClassifier, and ExtraTreesRegressor, as suggested.

Copy link
Member
@virchan virchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Ganasekhar-gif!

@adrinjalali, @marenwestermann, would you like to have a look and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0