-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC: Add link to plot_ensemble_oob example #31457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @Ganasekhar-gif!
I have a few comments.
sklearn/ensemble/_forest.py
Outdated
For an illustration of out-of-bag (OOB) error estimation, see the example | ||
:ref:`sphx_glr_auto_examples_ensemble_plot_ensemble_oob.py`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better placed under the oob_score
parameter in the docstring of RandomForestClassifier
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure i will make a new commit with this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the PR, @Ganasekhar-gif! I have a few more comments.
It'd be a good idea to include the example link in the docstrings of RandomForestRegressor
, ExtraTreesRegressor
, and ExtraTreesClassifier
.
…, ExtraTreesClassifier and ExtraTreesRegressor docstring
Hi @virchan! I've added references to the plot_ensemble_oob example in the docstrings of RandomForestRegressor, ExtraTreesClassifier, and ExtraTreesRegressor, as suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Ganasekhar-gif!
@adrinjalali, @marenwestermann, would you like to have a look and merge this?
Reference Issues/PRs
Towards #30621
What does this implement/fix? Explain your changes.
-Added description to the API documentation in sklearn.ensemble.RandomForestClassifier