8000 GOV more pragmatic decision making process for small PRs by lorentzenchr · Pull Request #31430 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

GOV more pragmatic decision making process for small PRs #31430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

GOV more pragmatic decision making process for small PRs #31430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions doc/governance.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,20 +146,22 @@ decision making process**".
Decisions (in addition to adding core contributors and TC membership as above)
are made according to the following rules:

* **Minor Documentation changes**, such as typo fixes, or addition / correction
* **Minor code and documentation changes**, such as small maintenance changes without
modification of code logic, typo fixes, or addition / correction
of a sentence, but no change of the ``scikit-learn.org`` landing page or the
“about” page: Requires +1 by a maintainer, no -1 by a maintainer (lazy
consensus), happens on the issue or pull request page. Maintainers are
expected to give “reasonable time” to others to give their opinion on the
“about” page: Requires +1 by a core contributor, no -1 by a core contributor
(lazy consensus), happens on the issue or pull request page. Core contributors
are expected to give “reasonable time” to others to give their opinion on the
pull request if they're not confident others would agree.

* **Code changes and major documentation changes**
require +1 by two maintainers, no -1 by a maintainer (lazy
require +1 by two core contributors, no -1 by a core contributor (lazy
consensus), happens on the issue of pull-request page.

* **Changes to the API principles and changes to dependencies or supported
versions** happen via :ref:`slep` and follows the decision-making process
outlined above.
versions** follow the decision-making process outlined above. In particular
changes to API principles are backed via a :ref:`slep`. Smaller decisions
like supported versions can happen on a GitHub issue or pull request.

* **Changes to the governance model** follow the process outlined in `SLEP020
<https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep020/proposal.html>`__.
Expand Down
0