8000 DOC fixes for LogisticRegression newton-cholesky and multiclass by lorentzenchr · Pull Request #31410 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC fixes for LogisticRegression newton-cholesky and multiclass #31410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

DOC fixes for LogisticRegression newton-cholesky and multiclass #31410

merged 4 commits into from
May 23, 2025

Conversation

lorentzenchr
Copy link
Member

Reference Issues/PRs

Not really

What does this implement/fix? Explain your changes.

This PR fixes some docstring and user guide shortcomings concerning LogisticRegression in the context of solver newton-cholesky and multinomial support (and some more bugs).

Any other comments?

@github-actions GitHub Actions
Copy link
github-actions bot commented May 21, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8d206e4. Link to the linter CI: here

@lorentzenchr
Copy link
Member Author

@jeremiedbb Might be worth to add it to v1.7 final release.

@lorentzenchr lorentzenchr added this to the 1.7 milestone May 21, 2025
@lorentzenchr lorentzenchr added the Quick Review For PRs that are quick to review label May 21, 2025
ogrisel
ogrisel approved these changes May 22, 2025
View reviewed changes 8000
Copy link
Member
@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the HTML rendering of the table is fixed.

lorentzenchr
lorentzenchr commented May 22, 2025
View reviewed changes
lorentzenchr
lorentzenchr commented May 22, 2025
View reviewed changes
@thomasjpfan thomasjpfan merged commit c219a6b into scikit-learn:main May 23, 2025
36 checks passed
@lorentzenchr lorentzenchr deleted the logistic_docstring branch May 27, 2025 05:02
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 30, 2025
@lorentzenchr @ogrisel @jeremiedbb
DOC fixes for LogisticRegression newton-cholesky and multiclass (scik…
cdeadf4 
…it-learn#31410)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
jeremiedbb pushed a commit that referenced this pull request Jun 5, 2025
@lorentzenchr @ogrisel @jeremiedbb
DOC fixes for LogisticRegression newton-cholesky and multiclass (#31410)
c914a9a 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:linear_model Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentzenchr @ogrisel @thomasjpfan
0