8000 [DOC] Make _fit_and_score return value docstring consistent with code. by rmcgibbo · Pull Request #3127 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[DOC] Make _fit_and_score return value docstring consistent with code. #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2014

Conversation

rmcgibbo
Copy link
Contributor
@rmcgibbo rmcgibbo commented May 2, 2014

The order of the return values currently listed in the cross_validation._fit_and_score docstring does not match the actual order of the return values when the kwarg return_train_score=True. In the code, this option causes the train_score to be the first return value, but in the docstring it's implied that it's the second.

This PR changes the docstring to be in sync with the code.

…docstring to reflect what the code actually does
@rmcgibbo
Copy link
Contributor Author
rmcgibbo commented May 2, 2014

This was mentioned before, right after #2736 was merged https://github.com/scikit-learn/scikit-learn/pull/2736/files#r8923738

@arjoly
Copy link
Member
arjoly commented May 2, 2014

Thanks merging.

arjoly added a commit that referenced this pull request May 2, 2014
[DOC] Make _fit_and_score return value docstring consistent with code.
@arjoly arjoly merged commit 29e9ed1 into scikit-learn:master May 2, 2014
@rmcgibbo rmcgibbo deleted the _fit_and_score-docstring branch May 2, 2014 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
42A2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0