TST Add unit tests for _BinaryClassifierCurveDisplayMixin
#31193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
It looks good @lucyleeow
@jeremiedbb maybe you can have a quick look.
jeremiedbb
reviewed
May 5, 2025
sklearn/utils/tests/test_plotting.py
Outdated
Comment on lines
28
to
31
| if name: | ||
| assert name_out == name | ||
| else: | ||
| assert name_out == display.estimator_name |
There was a problem hiding this comment.
maybe cleaner to set the expected value in the parametrization ?
There was a problem hiding this comment.
I added it to the name parametrization (so it is a tuple with input and expected output), this isn't very clean but wasn't sure how to do it as we parametrize over ax input too.
Let me know what you think / there's a better way to add it to the parametrization.
|
@jeremiedbb review addressed, gentle ping, thanks! |
jeremiedbb
reviewed
May 12, 2025
|
@jeremiedbb well that was a brain fart, don't know what I was thinking. Fixed. |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
May 30, 2025
jeremiedbb
pushed a commit
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Ref: #30399 (comment)
What does this implement/fix? Explain your changes.
As discussed with @glemaitre the
_BinaryClassifierCurveDisplayMixinmethods/class methods should be tested in isolation, as well as when used inside other classes.This adds unit tests for
_BinaryClassifierCurveDisplayMixinmethods.Any other comments?