DOC Add bumping dependencies guidelines to maintainer doc #31118
Conversation
| Example for the upcoming scikit-learn 1.8 release | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| The upcoming 1.8 release is scheduled around November/December, let's pretend | ||
| it will happen on 2025-12-01, Python 3.10 (released in October 2021) will be | ||
| more than 4 years old and will be dropped so our minimum supported Python will | ||
| be Python 3.11 (a bit more than 3 years old). | ||
|
|
||
| The dependencies minimum versions will be bumped as follow: | ||
|
|
||
| - python: 3.10 -> 3.11 | ||
| - numpy: 1.22.0 -> 1.24.0 (oldest version with Python 3.11 wheels) | ||
| - scipy: 1.8.0 -> 1.10.0 (oldest scipy version with Python 3.11 wheels) | ||
| - pandas: 1.4.0 -> 1.5.0 (oldest pandas version with Python 3.11 wheels) | ||
| - matplotlib: 3.5.0 -> 3.6.0 (oldest matplotlib version with Python 3.11 wheels) | ||
| - joblib: 1.2.0 -> 1.3.0 (1.3.0 will be ~2 years 5 month old, 1.4.0 will be less than 2 years old) | ||
| - threadpoolctl: 3.1.0 -> 3.2.0 (3.2.0 will be ~2 years 5 months old, 3.3.0 will be less than 2 years old) | ||
|
|
There was a problem hiding this comment.
I don't think this part is needed.
Instead we could consolidate and include the script you linked in #30895 (comment) in maint_tools and link that here :)
There was a problem hiding this comment.
I find an example helps understanding the rule but it also makes sense to keep it short. I guess I can always add a link to the github comment instead.
There was a problem hiding this comment.
I find that it quickly becomes out-of-date and we let very old examples with very old version numbers in the doc that we never update or clean-up.
At least we should rephrase it a bit such that it's not using time relative to now and use absolute timings instead. For instance the upcoming scikit-learn 1.8 release. Similarly, The dependencies minimum versions will be bumped as follow: should be The dependencies minimum versions should be bumped as follow:.
There was a problem hiding this comment.
I ended up adding the slightly hacky script I currently have. It can certainly be improved in future PRs.
Co-authored-by: Tim Head <betatim@gmail.com>
…rn#31118) Co-authored-by: Tim Head <betatim@gmail.com> Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
As discussed during the monthly scikit-learn developer meeting.
Close #30888.
I reused the content of #30888 (comment).
I propose to add a script in
maint_toolsbased on https://gist.github.com/lesteve/4a7d42bfaab461ab90fcdcc613d01081 in a separate PR.