8000 MNT Set pyamg version following our bumping rules by lesteve · Pull Request #31089 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Set pyamg version following our bumping rules #31089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2025
Merged

MNT Set pyamg version following our bumping rules #31089

merged 5 commits into from
Apr 1, 2025

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Mar 27, 2025 •
edited
Loading

4.2.0 is not available on conda-forge so I went for 4.2.1. I guess this falls under "there will be some exceptions sometimes" rule. We could install pyamg 4.2.0 with pip but I don't think this is worth the additional small complexity.

To be honest we may want to have 8000 a rule for core dependencies like numpy, scipy, pandas, matplotlib and another one for less core dependencies but I'll defer this to a separate issue.

This also fixes the fact that we were actually not testing against our minimum pyamg version.

See #30895 (comment) for more context.

Related to #30888. It was an oversight in #30895.

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 27, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 07aca32. Link to the linter CI: here

@lesteve lesteve changed the title MNT Set pyamg version tweak correctly MNT Set pyamg version following the rules Mar 27, 2025
@lesteve lesteve 8000 changed the title MNT Set pyamg version following the rules MNT Set pyamg version following our bumping rules Mar 27, 2025
jeremiedbb
jeremiedbb approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wouldn't mind keeping 5.0.0 as well

@ogrisel
Copy link
Member
ogrisel commented Mar 31, 2025

@lesteve feel free to merge after a re-update of the lock file with conflicts.

@lesteve lesteve merged commit a867ed7 into scikit-learn:main Apr 1, 2025
36 checks passed
@lesteve
Copy link
Member Author
lesteve commented Apr 1, 2025

I updated the lock-files and merged

lucyleeow pushed a commit to lucyleeow/scikit-learn that referenced this pull request Apr 2, 2025
@lesteve @lucyleeow
MNT Set pyamg version following our bumping rules (scikit-learn#31089)
c330ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @ogrisel @jeremiedbb
0