CI Use right environment in Pyodide wheel upload #31078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @lesteve!
Keeping environments fine-grained is nice, but it also causes a maintenance burden. Leaving it up to y'all to decide. :) |
This was referenced Mar 26, 2025
ogrisel
ap
8000
proved these changes
Mar 26, 2025
|
I think it's fine to reuse this env. |
|
Maybe @adrinjalali or @thomasjpfan for a second opinion on the security aspect of sharing the |
thomasjpfan
approved these changes
Mar 26, 2025
|
OK thanks, let's merge this then! |
|
Manual workflow now running at: https://github.com/scikit-learn/scikit-learn/actions/runs/14088599788 🤞 |
|
Pyodide wheels are on anaconda.org 🎉 https://anaconda.org/scientific-python-nightly-wheels/scikit-learn/files. |
lucyleeow
pushed a commit
to lucyleeow/scikit-learn
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #29791 after the upload fails #29791 (comment) because the token is empty.
Not sure if we should use the same environment or if we should have a separate environment for the main wheels upload and the Pyodide wheel upload. In particular the Pyodide wheel upload only needs
SCIKIT_LEARN_NIGHTLY_UPLOAD_TOKENand notSCIKIT_LEARN_STAGING_UPLOAD_TOKEN. cc @ogrisel.