8000 Revert "Make FrozenEstimator explicitly accept and ignore sample_weight" by OmarManzoor · Pull Request #30898 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Revert "Make FrozenEstimator explicitly accept and ignore sample_weight" #30898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

Revert "Make FrozenEstimator explicitly accept and ignore sample_weight" #30898

merged 1 commit into from
Feb 26, 2025

Conversation

OmarManzoor
Copy link
Contributor

Reverts #30874

Based on the points mentioned in #30874 (comment)

CC: @adrinjalali @ogrisel

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 3de4409. Link to the linter CI: here

adrinjalali
adrinjalali approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OmarManzoor

@adrinjalali adrinjalali merged commit 5eb676a into main Feb 26, 2025
41 of 42 checks passed
@adrinjalali adrinjalali deleted the revert-30874-enh-frozen-estimator-explicitly-ignore-sample_weight branch February 26, 2025 08:47
@adrinjalali
Copy link
Member

Seems like you created the branch on the main repo, probably by mistake 😁

@OmarManzoor
Copy link
Contributor Author

Seems like you created the branch on the main repo, probably by mistake 😁

Well I used the Github Revert option so I think it was created in the main repo. I think we might need to use a different option to create from our own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarManzoor @adrinjalali
0