DOC: Remove non-relevant comment in fetch_lfw_pairs documentation
#30871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoAmorQ
reviewed
Mar 3, 2025
There was a problem hiding this comment.
I think the information that the "pairs dataset" corresponds to the "restricted task" in the original publication is actually valuable. I would edit to something similar to:
In the `original paper <https://people.cs.umass.edu/~elm/papers/lfw.pdf>`_
the "pairs" version corresponds to the "restricted task", where
the experimenter should not use the name of a person to infer
the equivalence or non-equivalence of two face images that
are not explicitly given in the training set.
And then I agree that we should remove the comment on not supporting the "unrestricted version", which actually corresponds to the "people" version in my understanding of things.
|
@ArturoAmorQ Thank you for your feedback! I have added the narrative per your suggestion. |
fetch_lfw_pairs documentationfetch_lfw_pairs documentation
ArturoAmorQ
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #30800.
What does this implement/fix? Explain your changes.
Remove a comment in
fetch_lfw_pairsdocumentation about leaving the "unrestricted' variant unsupported.https://scikit-learn.org/dev/modules/generated/sklearn.datasets.fetch_lfw_pairs.html
The README.txt link does not work, so we rather mention the original paper.
Any other comments?