8000 MNT Fix Binder on 1.6 doc by lesteve · Pull Request #30862 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

MNT Fix Binder on 1.6 doc #30862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025
Merged

MNT Fix Binder on 1.6 doc #30862

merged 2 commits into from
Feb 20, 2025

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Feb 19, 2025

Backport of #30835 and #30697 to fix Binder links for the stable doc.

Binder seems to work on my branch: https://mybinder.org/v2/gh/lesteve/scikit-learn/binder-doc-1.6.

…n#30835)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Copy link
github-actions bot commented Feb 19, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8f3ce65. Link to the linter CI: here

@lesteve lesteve changed the title MNT: Check if running inside repo2docker more explicitly (#30835) MNT Fix Binder on 1.6 doc Feb 20, 2025
@lesteve lesteve merged commit 98ed9dc into scikit-learn:1.6.X Feb 20, 2025
36 of 37 checks passed
@lesteve lesteve deleted the binder-doc-1.6 branch February 20, 2025 07:16
@lesteve
Copy link
Member Author
lesteve commented Feb 20, 2025

Let's merge this to fix the Binder links on our stable doc.

@lesteve
Copy link
Member Author
lesteve commented Feb 20, 2025

Looks like Binder is working again on stable doc 🎉, for example https://mybinder.org/v2/gh/scikit-learn/scikit-learn/1.6.X?urlpath=lab/tree/notebooks/auto_examples/release_highlights/plot_release_highlights_1_5_0.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0