[MRG+1] added a new section on model persistence #3084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| In the specific case of the scikit, it may be more interesting to use | ||
| joblib's replacement of pickle (``joblib.dump`` & ``joblib.load``), | ||
| which is more efficient on big data, but can only pickle to the disk |
There was a problem hiding this comment.
...which is more efficient on objects that carry large numpy arrays internally as is often the case for fitted scikit-learn estimators.
|
Apart from my comments, this looks good. +1 for merge once they are addressed. |
|
Addressed ogrisel comments in 640bff9 |
| @@ -22,3 +22,4 @@ | |||
| Dataset loading utilities <datasets/index.rst> | |||
| modules/scaling_strategies.rst | |||
| modules/computational_performance.rst | |||
| model_persistence.rst | |||
There was a problem hiding this comment.
I'm not sure about this positioning. For example, after (or within) model selection and evaluation seems more coherent.
|
For the sake of consistency, I'd rather avoid the use of "you": we don't address the reader directly in the rest of the doc. Besides that +1 for merge once @jnothman 's comments have been taken into account. |
|
Fixed by #3317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1332