8000 :lock: :robot: CI Update lock files for main CI build(s) :lock: :robot: by scikit-learn-bot · Pull Request #30758 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

🔒 🤖 CI Update lock files for main CI build(s) 🔒 🤖 #30758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scikit-learn-bot
Copy link
Contributor

Update lock files.

Note

If the CI tasks fail, create a new branch based on this PR and add the required fixes to that branch.

Copy link
github-actions bot commented Feb 3, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fd8b6ee. Link to the linter CI: here

@ogrisel
Copy link
Member
ogrisel commented Feb 3, 2025

We have a few examples that need an update to work without raising a warning with the latest version of plotly:

  • examples/model_selection/plot_grid_search_text_feature_extraction.py
  • examples/ensemble/plot_forest_hist_grad_boosting_comparison.py

/cc @ArturoAmorQ since you are worked in the plot_grid_search_text_feature_extraction.py file in the past.

If supporting several older plotly versions makes the example too complicated, we can probably try to update the version of plotly in _min_dependencies.py and re-run the lock file update script.

@adrinjalali
Copy link
Member

That's a very odd message, here's the trace:

    Traceback (most recent call last):
      File "/home/circleci/project/examples/model_selection/plot_grid_search_text_feature_extraction.py", line 176, in <module>
        fig = px.scatter(
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/express/_chart_types.py", line 69, in scatter
        return make_figure(args=locals(), constructor=go.Scatter)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/express/_core.py", line 2756, in make_figure
        fig.update_layout(template=args["template"], overwrite=True)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/graph_objs/_figure.py", line 787, in update_layout
        return super(Figure, self).update_layout(dict1, overwrite, **kwargs)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 1392, in update_layout
        self.layout.update(dict1, overwrite=overwrite, **kwargs)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 5123, in update
        BaseFigure._perform_update(self, kwargs, overwrite=overwrite)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 3896, in _perform_update
        plotly_obj[key] = val
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 5898, in __setitem__
        super(BaseLayoutHierarchyType, self).__setitem__(prop, value)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 4852, in __setitem__
        self._set_compound_prop(prop, value)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 5263, in _set_compound_prop
        val = validator.validate_coerce(val, skip_invalid=self._skip_invalid)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/_plotly_utils/basevalidators.py", line 2797, in validate_coerce
        return super(BaseTemplateValidator, self).validate_coerce(
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/_plotly_utils/basevalidators.py", line 2508, in validate_coerce
        v = self.data_class(v)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/graph_objs/layout/_template.py", line 327, in __init__
        self["data"] = _v
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 4852, in __setitem__
        self._set_compound_prop(prop, value)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 5263, in _set_compound_prop
        val = validator.validate_coerce(val, skip_invalid=self._skip_invalid)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/_plotly_utils/basevalidators.py", line 2504, in validate_coerce
        v = self.data_class(v, skip_invalid=skip_invalid, _validate=_validate)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/graph_objs/layout/template/_data.py", line 1727, in __init__
        self["scattermapbox"] = _v
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 4856, in __setitem__
        self._set_array_prop(prop, value)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/basedatatypes.py", line 5337, in _set_array_prop
        val = validator.validate_coerce(val, skip_invalid=self._skip_invalid)
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/_plotly_utils/basevalidators.py", line 2596, in validate_coerce
        res.append(self.data_class(v_el, skip_invalid=skip_invalid))
      File "/home/circleci/miniforge3/envs/testenv/lib/python3.9/site-packages/plotly/graph_objs/_scattermapbox.py", line 2297, in __init__
        warn(
    DeprecationWarning: *scattermapbox* is deprecated! Use *scattermap* instead. Learn more at: https://plotly.com/python/mapbox-to-maplibre/

we're using neither scattermapbox nor scattermap, we're using scatter and it's not clear from the message what we need to change here. I'll open a plotly issue.

@adrinjalali
Copy link
Member

It's already reported here: plotly/plotly.py#4997

Comment on lines 1391 to 1395
WarningInfo(
"ignore",
message="*scattermapbox* is deprecated! Use *scattermap* instead.",
category=DeprecationWarning,
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WarningInfo(
"ignore",
message="*scattermapbox* is deprecated! Use *scattermap* instead.",
category=DeprecationWarning,
),
WarningInfo(
"ignore", message="scattermapbox", category=DeprecationWarning
),

Maybe this will be enough to fix the regexp parsing problem?

@lesteve lesteve merged commit e15b09e into scikit-learn:main Feb 6, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0