MNT Remove duplicated blank issue option #30710
Conversation
| @@ -1,4 +1,4 @@ | |||
| blank_issues_enabled: true | |||
| blank_issues_enabled: false | |||
There was a problem hiding this comment.
Last time I tested this I found that the https://github.com/scikit-learn/scikit-learn/issues/new does not exist, so the "Blank issue" on the bottom of this file does not work.
On your fork, does the link work now? (It should be https://github.com/lesteve/scikit-learn/issues/new on a fork)
There was a problem hiding this comment.
I push this PR branch in my fork main branch and https://github.com/lesteve/scikit-learn/issues/new works fine. I also double check that I can go to my fork issues click the "New issue" and select the blank template and it creates a blank issue.
There was a problem hiding this comment.
Maybe there is something subtle I am missing though because even the link with scikit-learn repo https://github.com/scikit-learn/scikit-learn/issues/new works for me ...
There was a problem hiding this comment.
In the past, https://github.com/.../scikit-learn/issues/new exists on main because blank_issues_enabled: true.
In any case, it looks like this works now. Lets merge and see if there is an issue here.
There was a problem hiding this comment.
Merged and checked that the link still works. 🥳
|
I don't know if this is just me but clicking on the blank issue item at the bottom:
sends me to (Alternatively maybe this was all just a clever ploy to prevent people from opening new blank issues? 😅 ) |
|
Oh well 🙄, I confirmed that I see the same behaviour as @lucyleeow. I am pretty sure I opened a blank issue since this PR was merged e.g. #30888 and this worked fine, but maybe this was relying on some undefined behaviour ... I guess reverting this PR is the easiest way forward ... maybe we want to remove the duplicated entry at the bottom? According to the doc there does not seem a way to tweak the "Blank issue" description (i.e. to encourage using Discussions instead as was previously done) |
|
Actually I found another way (which may be brittle, who knows what the future holds 😉). Here is a link that works to open a blank issue: https://github.com/scikit-learn/scikit-learn/issues/new?template=BLANK_ISSUE |
|
PR that fixes the "blank issue" link: #31038 |
on main Blank issue is duplicated
with this PR (tested on my fork)