8000 MNT Un-xfail SplitTransformer check_estimators_pickle common test by lesteve · Pull Request #30515 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

MNT Un-xfail SplitTransformer check_estimators_pickle common test #30515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 3, 2025
Merged

MNT Un-xfail SplitTransformer check_estimators_pickle common test #30515

merged 8 commits into from
Jan 3, 2025

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Dec 20, 2024 •
edited
Loading

Seen in #30512 (comment).

Scipy fixed it in 1.13 scipy/scipy#18153. It is currently broken again in 1.15dev scipy/scipy#22143. Edit: has been fixed in scipy-dev in scipy/scipy#22158.

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 20, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 671d15c. Link to the linter CI: here

@lesteve lesteve changed the title MNT Unxfail SplitTransformer check_estimators_pickle common test MNT Un-xfail SplitTransformer check_estimators_pickle common test Dec 20, 2024
@lesteve lesteve mentioned this pull request Dec 20, 2024
Closed
@lesteve
Copy link
Member Author
lesteve commented Dec 20, 2024 •
edited
Loading

So I guess there is still #30509 from numpy-dev:

FAILED metrics/tests/test_pairwise.py::test_euclidean_distances_extreme_values[1000000-float32-0.0001-1e-05] - AssertionError:

@lesteve lesteve marked this pull request as draft December 22, 2024 07:01
@lesteve
Copy link
Member Author
lesteve commented Dec 22, 2024 •
edited
Loading

Tests now pass because the numpy issue has been fixed.

Converting to draft until we see whether the scipy change in 1.15 is reverted scipy/scipy#22143 (comment)

@lesteve lesteve mentioned this pull request Dec 22, 2024
Closed
@lesteve lesteve marked this pull request as ready for review January 2, 2025 07:53
@lesteve
Copy link
Member Author
lesteve commented Jan 2, 2025 •
edited
Loading

The issue in scipy-dev has been fixed in scipy/scipy#22158, so this is ready for review.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jan 2, 2025
jeremiedbb
jeremiedbb approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member
@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd just add a comment to make it easier to find and remove when the time comes

@lesteve @jeremiedbb
Update sklearn/utils/_test_common/instance_generator.py
671d15c 
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
@jeremiedbb jeremiedbb enabled auto-merge (squash) January 3, 2025 15:32
@jeremiedbb jeremiedbb merged commit a8bef5f into scikit-learn:main Jan 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
module:utils Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesteve @thomasjpfan @jeremiedbb
0