API drop Tags.regressor_tags.multi_label #30373
Merged
+12
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changelog needed because this tag API has not been released yet. |
|
/cc @adrinjalali. |
|
This needs more fixes (tests failing). I'm not sure if the tag is used somewhere though, I wasn't sure about it when I wrote the new tags. |
|
Yes indeed, I am on it. |
|
This should be fixed now. As I said in the description, only I did not find any code that consumed that tag for regressor (besides the checks selftests). |
adrinjalali
approved these changes
Nov 29, 2024
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Dec 4, 2024
jeremiedbb
pushed a commit
that referenced
this pull request
Dec 6, 2024
virchan
pushed a commit
to virchan/scikit-learn
that referenced
this pull request
Dec 9, 2024
csadorf
added a commit
to csadorf/cuml
that referenced
this pull request
May 16, 2025
csadorf
added a commit
to csadorf/sklearn-compat
that referenced
this pull request
May 20, 2025
adrinjalali
pushed a commit
to sklearn-compat/sklearn-compat
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #29677 discovered while reviewing #30187.
Let's remove the field
tags.regressor_tags.multi_labelbecause:tags.target_tags.multi_outputautomatically set byMultioutputMixinfor regressors;Note that the bug was already present in
ForestRegressor._more_tagsbefore #29677, but since 1.6 is not released yet, let's fix this before making it officially part of our new Tag API.