-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
API drop Tags.regressor_tags.multi_label #30373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API drop Tags.regressor_tags.multi_label #30373
Conversation
No changelog needed because this tag API has not been released yet. |
/cc @adrinjalali. |
This needs more fixes (tests failing). I'm not sure if the tag is used somewhere though, I wasn't sure about it when I wrote the new tags. |
Yes indeed, I am on it. |
This should be fixed now. As I said in the description, only I did not find any code that consumed that tag for regressor (besides the checks selftests). |
Follow-up on #29677 discovered while reviewing #30187.
Let's remove the field
tags.regressor_tags.multi_label
because:tags.target_tags.multi_output
automatically set byMultioutputMixin
for regressors;Note that the bug was already present in
ForestRegressor._more_tags
before #29677, but since 1.6 is not released yet, let's fix this before making it officially part of our new Tag API.