8000 FIX proper inheritance for SGDOneClassSVM by glemaitre · Pull Request #30227 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX proper inheritance for SGDOneClassSVM #30227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

FIX proper inheritance for SGDOneClassSVM #30227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ab76f
FIX proper inheritance for SGDOneClassSVM
glemaitre Nov 5, 2024
37b9f0a
fix number pr
glemaitre Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whats_new/upcoming_changes/sklearn.linear_model/30227.fix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- :class:`~sklearn.linear_model.SGDOneClassSVM` now correctly inherits from
:class:`~sklearn.base.OutlierMixin` and the tags are correctly set.
By :user:`Guillaume Lemaitre <glemaitre>`
2 changes: 1 addition & 1 deletion sklearn/linear_model/_stochastic_gradient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,7 +2084,7 @@ def __sklearn_tags__(self):
return tags


class SGDOneClassSVM(BaseSGD, OutlierMixin):
class SGDOneClassSVM(OutlierMixin, BaseSGD):
"""Solves linear One-Class SVM using Stochastic Gradient Descent.

This implementation is meant to be used with a kernel approximation
Expand Down
10 changes: 10 additions & 0 deletions sklearn/linear_model/tests/test_sgd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from sklearn.pipeline import make_pipeline
from sklearn.preprocessing import LabelEncoder, MinMaxScaler, StandardScaler, scale
from sklearn.svm import OneClassSVM
from sklearn.utils import get_tags
from sklearn.utils._testing import (
assert_allclose,
assert_almost_equal,
Expand Down Expand Up @@ -2170,3 +2171,12 @@ def test_passive_aggressive_deprecated_average(Estimator):
est = Estimator(average=0)
with pytest.warns(FutureWarning, match="average=0"):
est.fit(X, Y)


def test_sgd_one_class_svm_estimator_type():
"""Check that SGDOneClassSVM has the correct estimator type.

Non-regression test for if the mixin was not on the left.
"""
sgd_ocsvm = SGDOneClassSVM()
assert get_tags(sgd_ocsvm).estimator_type == "outlier_detector"
0