10000 CI Fix action-towncrier-changelog whatsnew_pattern by lesteve · Pull Request #30124 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

CI Fix action-towncrier-changelog whatsnew_pattern #30124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

CI Fix action-towncrier-changelog whatsnew_pattern #30124

wants to merge 1 commit into from

Conversation

lesteve
8000
Copy link
Member
@lesteve lesteve commented Oct 21, 2024

Seen in #29705. Not sure what happened since I thought I tested this on my fork ...

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 35915bb. Link to the linter CI: here

@lesteve
Copy link
Member Author
lesteve commented Oct 21, 2024 •
edited
Loading

Hmmm actually looking a bit more at the https://github.com/scientific-python/action-towncrier-changelog/ code, whatsnew_pattern is only used when whatsnew_label is set as a label:
https://github.com/scientific-python/action-towncrier-changelog/blob/1d7332022f76e36fe8ce2d716b851f3f98063c62/check_changelog.py#L213-L214

matching_file is determined by an other way using known sections:
https://github.com/scientific-python/action-towncrier-changelog/blob/1d7332022f76e36fe8ce2d716b851f3f98063c62/check_changelog.py

Hmmm not sure what to do here 🤔 I am going to set this back to draft ...

I am guessing the reason the changelog check fails in #29705 is that because this adds sklearn.frozen as a new section and the action is using the main branch where this section has not been added yet ...

@lesteve lesteve marked this pull request as draft October 21, 2024 14:52
@adrinjalali
Copy link
Member

Can't we check the action against the PR branch?

@lesteve
Copy link
Member Author
lesteve commented Oct 22, 2024

I don't think so. The fact that the action is not using actions/checkout is discussed in scientific-python/action-towncrier-changelog#10 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @adrinjalali
0