TST be more specific in test_estimator_checks #29834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Sep 12, 2024
Member
There was a problem hiding this comment.
I think it makes sense. When we only add check_estimator it was potentially great to make sure that we get the right error calling check_estimator. Now that we use the parametrization, this is much better to have atomic tests as in this PR.
Charlie-XIAO
approved these changes
Sep 12, 2024
Contributor
There was a problem hiding this comment.
LGTM, but I was wondering why for some of the tests name is "test" while for others name is the estimator name? Do we want to be consistent here though it may not really matter?
Member
Author
|
The name only matters when we check exact values of raised exceptions, otherwise it really doesn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't add or remove any tests. It simply extracts a few tests into their own tests/functions, and uses the specific test instead of calling
check_estimatorwhich makes them resistant to changes in test orders and adding tests tocheck_estimator.cc @adam2392 @Charlie-XIAO