DOC Tweak documentation build doc #29749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Aug 30, 2024
betatim
reviewed
Aug 30, 2024
|
Sorry about the auto-merge, maybe should have posted a comment saying that I had turned it on (but I also wasn't expecting it to merge with pending review comments) |
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
No worries that's completely fine. I could have double-checked that auto-merge was not set. I could have chosen "Request changes" but I rarely do because I find it slightly too aggressive. Also I am not sure whether this blocks merging or not ... |
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #29743, looks auto-merge was set and my comments were not handled ...
cc @betatim