-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Tweak documentation build doc #29749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, otherwise good
Sorry about the auto-merge, maybe should have posted a comment saying that I had turned it on (but I also wasn't expecting it to merge with pending review comments) |
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
No worries that's completely fine. I could have double-checked that auto-merge was not set. I could have chosen "Request changes" but I rarely do because I find it slightly too aggressive. Also I am not sure whether this blocks merging or not ... |
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
Follow-up of #29743, looks auto-merge was set and my comments were not handled ...
cc @betatim