8000 DOC Tweak documentation build doc by lesteve · Pull Request #29749 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Tweak documentation build doc #29749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

lesteve
Copy link
Member
@lesteve lesteve commented Aug 30, 2024

Follow-up of #29743, looks auto-merge was set and my comments were not handled ...

cc @betatim

Copy link
github-actions bot commented Aug 30, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: de3e897. Link to the linter CI: here

Copy link
Member
@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, otherwise good

@betatim
Copy link
Member
betatim commented Aug 30, 2024

Sorry about the auto-merge, maybe should have posted a comment saying that I had turned it on (but I also wasn't expecting it to merge with pending review comments)

lesteve and others added 2 commits August 30, 2024 15:30
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
@lesteve
Copy link
Member Author
lesteve commented Aug 30, 2024

Sorry about the auto-merge, maybe should have posted a comment saying that I had turned it on (but I also wasn't expecting it to merge with pending review comments)

No worries that's completely fine. I could have double-checked that auto-merge was not set. I could have chosen "Request changes" but I rarely do because I find it slightly too aggressive. Also I am not sure whether this blocks merging or not ...

@lesteve lesteve enabled auto-merge (squash) August 30, 2024 13:33
@lesteve lesteve merged commit c53900e into scikit-learn:main Aug 30, 2024
28 checks passed
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
glemaitre pushed a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Tim Head <betatim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0